Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matching status #565

Merged
merged 19 commits into from
Nov 22, 2023
Merged

Matching status #565

merged 19 commits into from
Nov 22, 2023

Conversation

OlivierHecart
Copy link
Contributor

No description provided.

@OlivierHecart OlivierHecart added the new feature Something new is needed label Oct 10, 2023
@JEnoch JEnoch mentioned this pull request Oct 10, 2023
Merged
@JEnoch JEnoch mentioned this pull request Oct 13, 2023
Merged
@OlivierHecart OlivierHecart marked this pull request as ready for review November 9, 2023 16:50
p-avital
p-avital approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@p-avital p-avital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick comment on PublisherRef's double lifetimes, but I don't think it needs to be changed

zenoh/src/publication.rs Outdated Show resolved Hide resolved
@Mallets Mallets merged commit 7295201 into master Nov 22, 2023
15 checks passed
@Mallets Mallets deleted the matching_state branch November 22, 2023 15:54
@JEnoch JEnoch mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-avital p-avital p-avital approved these changes

@Mallets Mallets Mallets approved these changes

Assignees
No one assigned
Labels
new feature Something new is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OlivierHecart @Mallets @p-avital @JEnoch